From cae6008c036a4fe690ef1b87d0c953fd05d9d4a6 Mon Sep 17 00:00:00 2001 From: Max Audron Date: Sun, 22 Feb 2026 18:00:41 +0100 Subject: remove references from NetworkList input we do not need to reference stuff here and can just consume it --- src/message/signalproxy/objects/network.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/message/signalproxy/objects/network.rs') diff --git a/src/message/signalproxy/objects/network.rs b/src/message/signalproxy/objects/network.rs index 996dd80..6638996 100644 --- a/src/message/signalproxy/objects/network.rs +++ b/src/message/signalproxy/objects/network.rs @@ -54,6 +54,7 @@ impl Network { /// The `channel_modes` field is populated by the ``supports["CHANMODES"]` string, /// which is represented as the channel mode types a,b,c,d in a comma sepperated string. + #[allow(dead_code)] fn determine_channel_mode_types(&mut self) { let mut modes: Vec<&str> = self.supports.get("CHANMODES").unwrap().split(',').collect(); @@ -67,6 +68,7 @@ impl Network { .insert(ChannelModeType::AChanmode, modes.pop().unwrap().to_owned()); } + #[allow(dead_code)] fn determine_prefixes(&mut self) { let default_prefixes = vec!['~', '&', '@', '%', '+']; let default_prefix_modes = vec!['q', 'a', 'o', 'h', 'v']; @@ -369,14 +371,14 @@ impl crate::message::signalproxy::NetworkList for Network { } // TODO VariantList -> VariantMap conversion - fn from_network_list(input: &mut VariantList) -> Result { + fn from_network_list(input: VariantList) -> Result { let mut i = input.into_iter(); let mut map: VariantMap = VariantMap::new(); while let Some(key) = i.next() { - let key: String = key.clone().try_into()?; + let key: String = key.try_into()?; let value = i.next().ok_or(ProtocolError::MissingField(key.clone()))?; - map.insert(key, value.clone()); + map.insert(key, value); } Self::from_network_map(&mut map) @@ -552,8 +554,8 @@ impl NetworkList for Vec { Ok(self.iter().map(|b| Variant::NetworkServer(b.clone())).collect()) } - fn from_network_list(input: &mut super::VariantList) -> Result { - Ok(input.iter().map(|b| b.try_into().unwrap()).collect()) + fn from_network_list(input: super::VariantList) -> Result { + Ok(input.into_iter().map(|b| b.try_into().unwrap()).collect()) } } -- cgit v1.2.3