From cc542048e369dda0a773e1e3a4601dc7d20ff16a Mon Sep 17 00:00:00 2001
From: Max Audron <me@audron.dev>
Date: Sat, 21 Feb 2026 17:48:06 +0100
Subject: Syncable trait error handling

---
 src/message/signalproxy/objects/bufferviewconfig.rs | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'src/message/signalproxy/objects/bufferviewconfig.rs')

diff --git a/src/message/signalproxy/objects/bufferviewconfig.rs b/src/message/signalproxy/objects/bufferviewconfig.rs
index 286e83a..ade5bc5 100644
--- a/src/message/signalproxy/objects/bufferviewconfig.rs
+++ b/src/message/signalproxy/objects/bufferviewconfig.rs
@@ -15,7 +15,11 @@ pub struct BufferViewConfig {
     pub buffers: Vec<BufferId>,
     #[network(rename = "RemovedBuffers", network = "list", variant = "VariantList")]
     pub removed_buffers: Vec<BufferId>,
-    #[network(rename = "TemporarilyRemovedBuffers", network = "list", variant = "VariantList")]
+    #[network(
+        rename = "TemporarilyRemovedBuffers",
+        network = "list",
+        variant = "VariantList"
+    )]
     pub temporarily_removed_buffers: Vec<BufferId>,
 
     #[network(rename = "bufferViewId", default, skip)]
@@ -124,7 +128,7 @@ impl BufferViewConfig {
 
 #[cfg(feature = "client")]
 impl StatefulSyncableClient for BufferViewConfig {
-    fn sync_custom(&mut self, mut msg: crate::message::SyncMessage)
+    fn sync_custom(&mut self, mut msg: crate::message::SyncMessage) -> Result<(), crate::error::ProtocolError>
     where
         Self: Sized,
     {
@@ -144,12 +148,13 @@ impl StatefulSyncableClient for BufferViewConfig {
             }
             _ => (),
         }
+        Ok(())
     }
 }
 
 #[cfg(feature = "server")]
 impl StatefulSyncableServer for BufferViewConfig {
-    fn sync_custom(&mut self, mut msg: crate::message::SyncMessage)
+    fn sync_custom(&mut self, mut msg: crate::message::SyncMessage) -> Result<(), crate::error::ProtocolError>
     where
         Self: Sized,
     {
@@ -182,6 +187,7 @@ impl StatefulSyncableServer for BufferViewConfig {
             "setSortAlphabetically" => self.sort_alphabetically = msg.params.remove(0).try_into().unwrap(),
             _ => (),
         }
+        Ok(())
     }
 }
 
-- 
cgit v1.2.3

0ab3cdd7ea3a364030c144e16&amp;follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/catinator.git/log/deploy/vendor/github.com/jsonnet-libs/k8s-alpha'>
<input type='hidden' name='id' value='bf06821e77078c10ab3cdd7ea3a364030c144e16'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/catinator.git/log/?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>root</a>/<a href='/catinator.git/log/deploy?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>deploy</a>/<a href='/catinator.git/log/deploy/vendor?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>vendor</a>/<a href='/catinator.git/log/deploy/vendor/github.com?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>github.com</a>/<a href='/catinator.git/log/deploy/vendor/github.com/jsonnet-libs?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>jsonnet-libs</a>/<a href='/catinator.git/log/deploy/vendor/github.com/jsonnet-libs/k8s-alpha?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1&amp;follow=1'>k8s-alpha</a> (<a href='/catinator.git/log/deploy/vendor/github.com/jsonnet-libs/k8s-alpha?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;showmsg=1'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th></th><th class='left'>Commit message (<a href='/catinator.git/log/deploy/vendor/github.com/jsonnet-libs/k8s-alpha?id=bf06821e77078c10ab3cdd7ea3a364030c144e16&amp;follow=1'>Collapse</a>)</th><th class='left'>Author</th><th class='left'>Lines</th></tr>
<tr class='logheader'><td><span title='2021-05-26 08:35:21 +0200'>2021-05-26</span></td><td class='logsubject'><a href='/catinator.git/commit/src/hooks/sed.rs?id=47489582189b5b4f637717554029a95e7e22f871&amp;follow=1'>fix log breaking once buffer full</a></td><td>Max Audron</td><td><span class='deletions'>-2</span>/<span class='insertions'>+33</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='4' class='logmsg'>
the log_msg function was poping the newest message and replacing it with
the newest message, it should be poping the oldest messages.


</td></tr>
<tr class='logheader'><td><span title='2021-05-16 00:31:24 +0200'>2021-05-16</span></td><td class='logsubject'><a href='/catinator.git/commit/src/lib.rs?id=bda302df12856879fd78efad1569135b1706973b&amp;follow=1'>add deployment stuff</a></td><td>Max Audron</td><td><span class='deletions'>-6</span>/<span class='insertions'>+27786</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='4' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span title='2021-05-15 14:18:59 +0200'>2021-05-15</span></td><td class='logsubject'><a href='/catinator.git/commit/Containerfile?id=5340979d23da14a98dce7210a5f00821c62ff8f1&amp;follow=1'>add container build</a></td><td>Max Audron</td><td><span class='deletions'>-2</span>/<span class='insertions'>+35</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='4' class='logmsg'>
</td></tr>